njayaram2 commented on a change in pull request #389: DL: Convert the
keras_eval function from UDF to UDA
URL: https://github.com/apache/madlib/pull/389#discussion_r283052070
##########
File path:
src/ports/postgres/modules/deep_learning/test/unit_tests/test_madlib_keras.py_in
##########
@@ -803,6 +810,267 @@ class MadlibKerasHelperTestCase(unittest.TestCase):
self.subject.strip_trailing_nulls_from_class_values(
[None, None]))
+
+class MadlibKerasEvaluationTestCase(unittest.TestCase):
+ def setUp(self):
+ self.plpy_mock = Mock(spec='error')
+ patches = {
+ 'plpy': plpy,
+ 'utilities.minibatch_preprocessing': Mock()
Review comment:
Why do we need to mock `utilities.minibatch_preprocessing`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services