reductionista commented on a change in pull request #394: DL: Add model_arch
column to model data table
URL: https://github.com/apache/madlib/pull/394#discussion_r285802228
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -321,9 +321,10 @@ def fit(schema_madlib, source_table,
model,model_arch_table,
description, aggregate_runtime, class_values])
create_output_table = plpy.prepare("""
- CREATE TABLE {0} AS
- SELECT $1 as model_data""".format(model), ["bytea"])
- plpy.execute(create_output_table, [model_state])
+ CREATE TABLE {0} AS SELECT
+ $1 as model_data,
+ $2 as {1}""".format(model, Format.MODEL_ARCH), ["bytea", "text"])
Review comment:
I think the type should be JSON rather than TEXT:
$2::JSON as {1} ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
