kaknikhil commented on a change in pull request #397: DL: Update content of
the model summary table
URL: https://github.com/apache/madlib/pull/397#discussion_r287543971
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
##########
@@ -160,7 +172,7 @@ def parse_and_validate_compile_params(str_of_args):
opt_args: Arguments for the optimizer
compile_dict: Dictionary of arguments for keras.compile
"""
-
+ _assert(str_of_args, "Compile parameters cannot be empty or NULL.")
Review comment:
line no 69 in keras fit `compile_params = "" if not compile_params else
compile_params` sets compile_params to "" if they are null.
Then by the time `parse_and_validate_compile_params` gets called, we
surround compile params with $MAD$ (line 149). so compile params will never be
null when this function gets called
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
