njayaram2 commented on a change in pull request #397: DL: Update content of
the model summary table
URL: https://github.com/apache/madlib/pull/397#discussion_r288349089
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -85,14 +66,17 @@ def fit(schema_madlib, source_table,
model,model_arch_table,
independent_varname = MINIBATCH_OUTPUT_INDEPENDENT_COLNAME_DL
model_arch_table = quote_ident(model_arch_table)
fit_params = "" if not fit_params else fit_params
+ compile_params = "" if not compile_params else compile_params
fit_validator = FitInputValidator(
source_table, validation_table, model, model_arch_table,
- dependent_varname, independent_varname, num_iterations,
- metrics_compute_frequency)
+ dependent_varname, independent_varname,
+ num_iterations, metrics_compute_frequency)
if metrics_compute_frequency is None:
metrics_compute_frequency = num_iterations
+ # The following two times must be recorded together.
+ metrics_elapsed_start_time = time.time()
Review comment:
The variable names reflect the corresponding column names in the output
summary table, so I would actually prefer keeping `start_training_time` as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
