khannaekta commented on a change in pull request #395: DL:
madlib_keras_evaluate() function
URL: https://github.com/apache/madlib/pull/395#discussion_r289488748
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
##########
@@ -253,32 +253,25 @@ CREATE OR REPLACE FUNCTION
MADLIB_SCHEMA.internal_keras_predict(
$$ LANGUAGE plpythonu VOLATILE
m4_ifdef(`__HAS_FUNCTION_PROPERTIES__', `MODIFIES SQL DATA', `');
-CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.madlib_keras_evaluate1(
+CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.madlib_keras_evaluate(
model_table VARCHAR,
test_table VARCHAR,
- id_col VARCHAR,
- model_arch_table VARCHAR,
- model_arch_id INTEGER,
- dependent_varname VARCHAR,
- independent_varname VARCHAR,
- compile_params VARCHAR,
- output_table VARCHAR
+ output_table VARCHAR,
+ gpus_per_host INTEGER
) RETURNS VOID AS $$
- PythonFunctionBodyOnly(`deep_learning', `madlib_keras')
- with AOControl(False):
Review comment:
We changed this function to call `PythonFunction` instead of
`PythonFunctionBodyOnly` and `PythonFunction` internally calls `with
AOControl(False):`. Therefore, removed it from here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
