kaknikhil commented on a change in pull request #405: Fix tensorflow crashes
URL: https://github.com/apache/madlib/pull/405#discussion_r291330113
##########
File path: src/library.ver
##########
@@ -1,11 +1,15 @@
VERS_1.0 {
local:
- _Znwm;
- _ZnwmRKSt9nothrow_t;
- _ZdlPv;
- _ZdlPvRKSt9nothrow_t;
- _Znam;
- _ZnamRKSt9nothrow_t;
- _ZdaPv;
- _ZdaPvRKSt9nothrow_t;
+ _Znwm; # operator new(unsigned long);
+ _ZnwmRKSt9nothrow_t; # operator new(unsigned long, std::nothrow_t
const&);
+ _ZdlPv; # operator delete(void*);
+ _ZdlPvRKSt9nothrow_t; # operator delete(void*, std::nothrow_t const&);
+ _Znam; # operator new[](unsigned long);
+ _ZnamRKSt9nothrow_t; # operator new[](unsigned long, std::nothrow_t
const&);
+ _ZdaPv; # operator delete[](void*);
+ _ZdaPvRKSt9nothrow_t; # operator delete[](void*, std::nothrow_t
const&);
+
+ extern "C++" {
Review comment:
Can we add a comment here explaining why we need to hide these?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
