orhankislal commented on a change in pull request #412: DL: Standardize the data types used for keras and sql URL: https://github.com/apache/madlib/pull/412#discussion_r293986603
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras_helper.py_in ########## @@ -160,3 +164,7 @@ METRIC_TYPE_COLNAME = "metrics_type" # MADLIB-1300 Adding these variables for DL only at this time. MINIBATCH_OUTPUT_DEPENDENT_COLNAME_DL = "dependent_var" MINIBATCH_OUTPUT_INDEPENDENT_COLNAME_DL = "independent_var" + +## sql variable types Review comment: Maybe we should define these constants at the top of the file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
