makemebitter commented on a change in pull request #422: Correlation: Process
deconstruction in chunks for grouping
URL: https://github.com/apache/madlib/pull/422#discussion_r303111652
##########
File path: src/ports/postgres/modules/stats/correlation.py_in
##########
@@ -330,9 +355,11 @@ def _create_deconstruction_query(schema_madlib,
col_names, grouping_cols,
the matrix to deconstruct
@param cor_mat Name of column that containss the matrix
to deconstruct
+ @param n_groups_per_run Number of groups to deconstruct in a single
+ sub-query
Returns:
- String (SQL querry for deconstructing the matrix)
+ List of Strings (each string is a SQL sub-query for deconstructing the
matrix)
Review comment:
maybe also add that each subquery in the return list contains n groups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
