reductionista commented on a change in pull request #424: DL: Add function for predict bring your own model URL: https://github.com/apache/madlib/pull/424#discussion_r309936344
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras_predict.py_in ########## @@ -18,90 +18,197 @@ # under the License. import plpy -import os import keras from keras import backend as K from keras.layers import * from keras.models import * from keras.optimizers import * +from model_arch_info import * from madlib_keras_helper import * -from madlib_keras_validator import PredictInputValidator +from madlib_keras_validator import * from predict_input_params import PredictParamsProcessor from utilities.control import MinWarning -from utilities.model_arch_info import get_input_shape +from utilities.utilities import _assert from utilities.utilities import add_postfix from utilities.utilities import create_cols_from_array_sql_string from utilities.utilities import get_segments_per_host -from utilities.utilities import is_platform_pg from utilities.utilities import unique_string +from utilities.validate_args import input_tbl_valid +from utilities.validate_args import quote_ident from madlib_keras_wrapper import * -MODULE_NAME = 'madlib_keras_predict' +class BasePredict(): Review comment: Nice job on the refactor, this looks good! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
