kaknikhil commented on a change in pull request #425: DL: Add training for multiple models URL: https://github.com/apache/madlib/pull/425#discussion_r310262753
########## File path: src/ports/postgres/modules/deep_learning/test/madlib_keras.sql_in ########## @@ -1179,3 +1180,93 @@ SELECT assert( abs(first.training_metrics_final-second.training_metrics[2]) < 1e-10, 'Transfer learning test failed because training loss and metrics don''t match the expected value.') FROM iris_model_first_run AS first, iris_model_transfer_summary AS second; + Review comment: We might want to add asserts similar to madlib_keras_fit to check for the fact that we are indeed learning. I would suggest reviewing all the tests we have for the `madlib_keras_fit` and maybe add similar tests for this function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
