njayaram2 commented on a change in pull request #430: Add generate mst table utility. URL: https://github.com/apache/madlib/pull/430#discussion_r312129329
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in ########## @@ -1750,6 +1750,20 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.madlib_keras_fit( $$ LANGUAGE sql VOLATILE m4_ifdef(`__HAS_FUNCTION_PROPERTIES__', `MODIFIES SQL DATA'); +CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.madlib_keras_generate_mst_table( + model_selection_table VARCHAR, + model_arch_table VARCHAR, Review comment: Interfaces in other modules normally have input table as the first param. Since `model_selection_table` is the output of this module, we should probably swap the order of the first two params. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
