kaknikhil commented on issue #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA URL: https://github.com/apache/madlib/pull/432#issuecomment-527642918 Few more general comments 1. The commit title should have the module name and not the jira no i.e. `LDA : Added stopping criteria on perplexity`. 1. The commit is missing details and the JIRA no. We should add a verbose commit message (including the motivation for excluding the first iteration for calculating perplexity). 1. URL for the jira in the PR message is incorrect. It is pointing to the apache madlib pull request url instead of apache madlib jira
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
