kaknikhil commented on a change in pull request #435: Separate mst module from
fit_multiple_models module
URL: https://github.com/apache/madlib/pull/435#discussion_r320962610
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_validator.py_in
##########
@@ -352,6 +352,10 @@ class MstLoaderInputValidator():
)
)
def _validate_compile_and_fit_params(self):
+ if not self.fit_params_list:
+ plpy.error(
Review comment:
why break up this line of code in three, why not just do
```
plpy.error("fit_params_list cannot be NULL")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
