hpandeycodeit commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA URL: https://github.com/apache/madlib/pull/432#discussion_r321872846
########## File path: src/ports/postgres/modules/lda/test/lda.sql_in ########## @@ -288,3 +288,57 @@ CREATE OR REPLACE FUNCTION validate_lda_output() RETURNS integer AS $$ $$ LANGUAGE plpgsql; select validate_lda_output(); + + +---------- TEST CASES FOR PERPLEXITY ---------- + +drop table if exists lda_model, lda_output_data; +SELECT lda_train( Review comment: Added tests for 2 and 4. There are few outstanding tests like 1,3 and 5 for which I need some more clarity. I will discuss with you on that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
