kaknikhil commented on a change in pull request #433: Kmeans: Add automatic
optimal cluster estimation
URL: https://github.com/apache/madlib/pull/433#discussion_r322364226
##########
File path: src/ports/postgres/modules/kmeans/test/kmeans.sql_in
##########
@@ -91,6 +91,59 @@ SELECT * FROM kmeans('kmeans_2d', 'array[x,y]',
'centroids', 'array[x,y]');
SELECT * FROM kmeanspp('kmeans_2d', 'array[x,y]', 10);
SELECT * FROM kmeans_random('kmeans_2d', 'arRAy [ x,y]', 10);
+-- Test kmeanspp_auto
Review comment:
We can add asserts like
1. Count of the output table
1. Make sure all the k values are as expected
1. Other metadata like `selection_algo`, `num_iterations` etc.
etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
