kaknikhil commented on a change in pull request #441: Kmeans: simplified
silhouette per point for k-means
URL: https://github.com/apache/madlib/pull/441#discussion_r325339353
##########
File path: src/ports/postgres/modules/kmeans/kmeans.sql_in
##########
@@ -1733,3 +1733,57 @@ AS $$
'MADLIB_SCHEMA.dist_norm2')
$$
m4_ifdef(`__HAS_FUNCTION_PROPERTIES__', `READS SQL DATA', `');
+
+
+CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.simple_silhouette_points(
+ rel_source VARCHAR,
+ output_table VARCHAR,
+ pid VARCHAR,
+ expr_point VARCHAR,
+ centroids_table VARCHAR,
+ centroids_col VARCHAR,
+ fn_dist VARCHAR /*+ DEFAULT 'dist_norm2' */
+) RETURNS VOID AS $$
+ PythonFunction(kmeans, kmeans, simple_silhouette_points_str_wrapper)
+$$ LANGUAGE plpythonu VOLATILE
+m4_ifdef(`\_\_HAS_FUNCTION_PROPERTIES\_\_', `MODIFIES SQL DATA', `');
+
+CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.simple_silhouette_points(
+ rel_source VARCHAR,
+ output_table VARCHAR,
+ pid VARCHAR,
+ expr_point VARCHAR,
+ centroids_table VARCHAR,
+ centroids_col VARCHAR
+) RETURNS VOID
+AS $$
+ SELECT MADLIB_SCHEMA.simple_silhouette_points($1, $2, $3, $4, $5, $6,
+ 'MADLIB_SCHEMA.dist_norm2')
+$$ LANGUAGE sql VOLATILE
+m4_ifdef(`\_\_HAS_FUNCTION_PROPERTIES\_\_', `MODIFIES SQL DATA', `');
+
+
+CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.simple_silhouette_points(
+ rel_source VARCHAR,
+ output_table VARCHAR,
+ pid VARCHAR,
+ expr_point VARCHAR,
+ centroids DOUBLE PRECISION[],
+ fn_dist VARCHAR /*+ DEFAULT 'dist_norm2' */
+) RETURNS VOID AS $$
+ PythonFunction(kmeans, kmeans, simple_silhouette_points_dbl_wrapper)
+$$ LANGUAGE plpythonu VOLATILE
+m4_ifdef(`\_\_HAS_FUNCTION_PROPERTIES\_\_', `MODIFIES SQL DATA', `');
+
+CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.simple_silhouette_points(
+ rel_source VARCHAR,
+ output_table VARCHAR,
+ pid VARCHAR,
+ expr_point VARCHAR,
+ centroids DOUBLE PRECISION[]
+) RETURNS VOID
+AS $$
+ SELECT MADLIB_SCHEMA.simple_silhouette_points($1, $2, $3, $4, $5,
+ 'MADLIB_SCHEMA.dist_norm2')
+$$ LANGUAGE sql VOLATILE
+m4_ifdef(`\_\_HAS_FUNCTION_PROPERTIES\_\_', `MODIFIES SQL DATA', `');
Review comment:
new line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
