kaknikhil commented on a change in pull request #443: DL: Add training for
multiple models
URL: https://github.com/apache/madlib/pull/443#discussion_r326744457
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_validator.py_in
##########
@@ -421,3 +421,50 @@ class MstLoaderInputValidator():
output_tbl_valid(self.model_selection_table, self.module_name)
output_tbl_valid(self.model_selection_summary_table, self.module_name)
+
+class FitMultipleInputValidator(FitInputValidator):
+ def __init__(self, source_table, validation_table, output_model_table,
+ model_arch_table, dependent_varname,
+ independent_varname, num_iterations,
+ metrics_compute_frequency, warm_start):
+ super(FitMultipleInputValidator, self).__init__(source_table,
+ validation_table,
+ output_model_table,
+ model_arch_table,
+ None,
+ dependent_varname,
+ independent_varname,
+ num_iterations,
+
metrics_compute_frequency,
+ warm_start)
+
+ def _validate_input_args(self):
Review comment:
We have copied over almost all of the `_validate_input_args` from
`FitInputValidator`. Instead we should take out all the common code and maybe
create a function in the base class which will be called in the base class'
init function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
