reductionista commented on a change in pull request #449: DL: Use REAL[] instead of anyarray for aggregating arrays URL: https://github.com/apache/madlib/pull/449#discussion_r334671710
########## File path: src/ports/postgres/modules/deep_learning/input_data_preprocessor.sql_in ########## @@ -849,3 +857,13 @@ import numpy as np return np.frombuffer(var, dtype=np.float32) Review comment: I must have missed this last time, but shouldn't this be `tobytes()` instead of `frombuffer()`? (For function `convert_array_to_bytea()`) Also, maybe we should rename it to `convert_real_array_to_bytea()` now that we have two different array types. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
