kaknikhil commented on a change in pull request #451: DL: Update evaluate and
predict for multi model outputs
URL: https://github.com/apache/madlib/pull/451#discussion_r336610671
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_helper.py_in
##########
@@ -225,3 +227,19 @@ def query_weights(model_output_table, model_weights_col,
mst_key_col, mst_key):
res = plpy.execute(mlp_weights_query)
return res[0][model_weights_col]
+
+def create_summary_view(model_table, mst_key):
+ tmp_view_summary = unique_string('tmp_view_summary')
+ model_summary_table = add_postfix(model_table, "_summary")
+ model_info_table = add_postfix(model_table, "_info")
+ if not (table_exists(model_summary_table) and
+ table_exists(model_info_table)):
+ plpy.error("{0}: Missing table".format(module_name))
+
+ plpy.execute("""
+ CREATE VIEW {tmp_view_summary} AS
+ SELECT *, 1::SMALLINT AS {model_arch_id_colname}
Review comment:
I am assuming that we don't care about the model arch id and that's why it
is always set to 1? If that's the case, I would suggest making it NULL so that
the intention is clear and it will help prevent any regressions in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
