reductionista commented on a change in pull request #459: DL: Add support for
asymmetric segment distribution to preprocessor
URL: https://github.com/apache/madlib/pull/459#discussion_r348208110
##########
File path:
src/ports/postgres/modules/deep_learning/input_data_preprocessor.py_in
##########
@@ -204,42 +207,90 @@ class InputDataPreprocessorDL(object):
dep_shape = self._get_dependent_var_shape()
dep_shape = ','.join([str(i) for i in dep_shape])
- # Create the mini-batched output table
if is_platform_pg():
distributed_by_clause = ''
dist_key_clause = ''
join_clause = ''
select_clause = 'b.*'
Review comment:
I guess this was already in the code, but just happened to notice that this
`select clause` isn't used anywhere. I think we can just remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
