reductionista commented on a change in pull request #462: DL: Add asymmetric
cluster support for fit and evaluate
URL: https://github.com/apache/madlib/pull/462#discussion_r352950468
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.py_in
##########
@@ -106,15 +107,23 @@ class FitMultipleModel():
self.info_str = ""
self.dep_shape_col = add_postfix(mb_dep_var_col, "_shape")
self.ind_shape_col = add_postfix(mb_indep_var_col, "_shape")
+ self.use_gpus = use_gpus
+ self.segments_per_host = get_segments_per_host()
+ if self.use_gpus:
+ self.gpus_per_seg = get_gpus_per_seg(self.schema_madlib,
+ self.segments_per_host, self.module_name)
+ else:
+ self.gpus_per_seg = get_seg_number()*[0]
+
self.fit_validator_train = FitMultipleInputValidator(
self.source_table, self.validation_table, self.model_output_table,
self.model_selection_table, self.model_selection_summary_table,
mb_dep_var_col, mb_indep_var_col, self.num_iterations,
self.model_info_table, self.mst_key_col, self.model_arch_table_col,
- 1, False)
+ 1, False, self.use_gpus, self.gpus_per_seg)
self.msts = self.fit_validator_train.msts
self.model_arch_table = self.fit_validator_train.model_arch_table
- self.seg_ids_train, self.images_per_seg_train = \
+ self.dist_key_mapping, self.images_per_seg_train = \
Review comment:
I noticed we rename `seg_ids_train` to `dist_key_mapping`. But then we
leave `seg_ids_valid` the same; if I'm understanding this right, seems like we
should have a `dist_key_mapping_train` and `dist_key_mapping_valid`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
