khannaekta commented on a change in pull request #464: Build: Add support for
pg 12
URL: https://github.com/apache/madlib/pull/464#discussion_r360521117
##########
File path: src/ports/postgres/dbconnector/Backend.hpp
##########
@@ -102,17 +102,27 @@ MADLIB_WRAP_VOID_PG_FUNC(
(typid, typlen, typbyval, typalign)
)
+#if PG_VERSION_NUM >= 120000
inline
void
+madlib_InitFunctionCallInfoData(FunctionCallInfoBaseData& fcinfo, FmgrInfo*
flinfo,
+ short nargs, Oid fncollation, fmNodePtr context, fmNodePtr resultinfo) {
+#else
+void
madlib_InitFunctionCallInfoData(FunctionCallInfoData& fcinfo, FmgrInfo* flinfo,
short nargs, Oid fncollation, fmNodePtr context, fmNodePtr resultinfo) {
+#endif
#if PG_VERSION_NUM >= 90100
// Collation support has been added to PostgreSQL with commit
// d64713df by Tom Lane <[email protected]>
// on Tue Apr 12 2011 23:19:24 UTC. First release: PG9.1.
InitFunctionCallInfoData(fcinfo, flinfo, nargs, fncollation, context,
resultinfo);
+
+// #if PG_VERSION_NUM >= 120000
Review comment:
We can probably remove the following commented code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
