orhankislal commented on a change in pull request #467: DL: Improve performance 
of mini-batch preprocessor
URL: https://github.com/apache/madlib/pull/467#discussion_r362650926
 
 

 ##########
 File path: 
src/ports/postgres/modules/deep_learning/input_data_preprocessor.py_in
 ##########
 @@ -190,6 +207,52 @@ class InputDataPreprocessorDL(object):
             shape = parse_shape(shape)
         return shape
 
+    def run_batch_rows_query(self, local_vars):
 
 Review comment:
   We should pick a better name, something like `create_batched_table` might 
work better. run...query doesn't really help  us understand what the function 
is doing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to