kaknikhil commented on issue #494: Update version to 1.18.0-dev URL: https://github.com/apache/madlib/pull/494#issuecomment-615439244 These changes LGTM. But as soon as we push this commit, the madlib_keras.sql_in and madlib_keras_fit_multiple_model.sql_in dev check tests will start failing because they hardcode the version no. We should instead test that the madlib_version column is not null instead of a specific version. See https://github.com/apache/madlib/commit/186a28b6380bd44a87f5240ff9aabd836e023594 for more details
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
