fmcquillan99 commented on pull request #496:
URL: https://github.com/apache/madlib/pull/496#issuecomment-623785188
(1)
```
madlib=# select madlib.dbscan('usage')
;
dbscan
-------------------------------------------------------------------------------
-----------------------------------------------------------------------
USAGE
-----------------------------------------------------------------------
SELECT madlib.dbscan(
source_table, -- Name of the training data table
output_table, -- Name of the output table
id_column, -- Name of id column in source_table
expr_point, -- Column name or expression for data points
eps, -- The minimum radius of a cluster
min_samples, -- The minimum size of a cluster
metric -- The name of the function to use to calculate the
-- distance
algorithm -- The algorithm to use for dbscan.
);
```
Missing comma after metric
(2)
```
madlib=# select madlib.dbscan_predict('usage')
;
ERROR: function madlib.dbscan_predict(unknown) does not exist
LINE 1: select madlib.dbscan_predict('usage')
^
HINT: No function matches the given name and argument types. You might need
to add explicit type casts.
```
This usage function seems to be missing
(3) Suggest make following params optional:
```
min_samples, default: 5
metric, default: 'squared_dist_norm2'
algorithm, default: 'brute_force'
```
(4) Can you give me an example of how you would do batch prediction?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]