khannaekta commented on a change in pull request #503:
URL: https://github.com/apache/madlib/pull/503#discussion_r453799003



##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
##########
@@ -331,3 +337,32 @@ def validate_compile_param_types(compile_dict):
             compile_dict['sample_weight_mode'] is None or
             compile_dict['sample_weight_mode'] == "temporal",
             """compile parameter sample_weight_mode can only be "temporal" or 
None""")
+
+# Returns an object of custom function name and it corresponding object
+def query_custom_functions_map(object_table, custom_fn_names):
+    if len(custom_fn_names) < 1:

Review comment:
       The `custom_fn_names` are passed in as what is returned from 
`get_custom_functions_list()` which is returns a list (empty or with values). 
Therefore, skipped checking for`None` for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to