fmcquillan99 edited a comment on pull request #506:
URL: https://github.com/apache/madlib/pull/506#issuecomment-668947847
From my previous comments:
1,2,3,4,5,7 are fixed
6 is OK as is, no fix needed
Additional questions:
(8)
is this the right syntax for an optimizer with no params? i.e., `Adagrad()`
```
optimizer='Adagrad()',metrics=['accuracy'],loss='categorical_crossentropy'
```
(9)
if I did not put an optimizer:
```
DROP TABLE IF EXISTS mst_table, mst_table_summary;
SELECT madlib.generate_model_configs(
'model_arch_library', -- model
architecture table
'mst_table', -- model
selection table output
ARRAY[1,2], -- model
ids from model architecture table
$$
{'loss':
['categorical_crossentropy'],
'optimizer_params_list': [
{'lr': [0.0001, 0.1, 'log']} ],
'metrics': ['accuracy']}
$$, -- compile_param_grid
$$
{ 'batch_size': [8],
'epochs': [1]
}
$$, -- fit_param_grid
'random', -- search_type (‘grid’ or
‘random’, default ‘grid’)
2, -- num_configs (number of
sampled parameters. Default=10) [to limit testing]
NULL, -- random_state
NULL -- object table (Default=None)
);
```
then `SGD` shows up:
```
mst_key | model_id | compile_params
| fit_params
---------+----------+-----------------------------------------------------------------------------------------------+-----------------------
1 | 1 |
optimizer='SGD(lr=0.002963575680717671)',metrics=['accuracy'],loss='categorical_crossentropy'
| epochs=1,batch_size=8
2 | 2 |
optimizer='SGD(lr=0.027802557490831045)',metrics=['accuracy'],loss='categorical_crossentropy'
| epochs=1,batch_size=8
(2 rows)
```
Do we do that or does Keras do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
