khannaekta commented on a change in pull request #526:
URL: https://github.com/apache/madlib/pull/526#discussion_r555388554
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_automl.py_in
##########
@@ -172,45 +183,38 @@ class KerasAutoML(object):
random_state = 'NULL' if self.random_state is None else
'$MAD${0}$MAD$'.format(self.random_state)
validation_table = 'NULL' if self.validation_table is None else
'$MAD${0}$MAD$'.format(self.validation_table)
- create_query = plpy.prepare("""
+ create_query = """
CREATE TABLE {self.model_summary_table} AS
SELECT
$MAD${self.source_table}$MAD$::TEXT AS source_table,
{validation_table}::TEXT AS validation_table,
$MAD${self.model_output_table}$MAD$::TEXT AS model,
$MAD${self.model_info_table}$MAD$::TEXT AS model_info,
- (SELECT dependent_varname FROM
{model_training.model_summary_table})
- AS dependent_varname,
- (SELECT independent_varname FROM
{model_training.model_summary_table})
- AS independent_varname,
+ (SELECT dependent_varname FROM {a.MODEL_SUMMARY_TABLE})
+ AS dependent_varname,
+ (SELECT independent_varname FROM {a.MODEL_SUMMARY_TABLE})
+ AS independent_varname,
$MAD${self.model_arch_table}$MAD$::TEXT AS
model_arch_table,
$MAD${self.model_selection_table}$MAD$::TEXT AS
model_selection_table,
$MAD${self.automl_method}$MAD$::TEXT AS automl_method,
$MAD${self.automl_params}$MAD$::TEXT AS automl_params,
{random_state}::TEXT AS random_state,
{object_table}::TEXT AS object_table,
{self.use_gpus} AS use_gpus,
- (SELECT metrics_compute_frequency FROM
{model_training.model_summary_table})::INTEGER
- AS metrics_compute_frequency,
- {name}::TEXT AS name,
- {descr}::TEXT AS description,
+ (SELECT metrics_compute_frequency FROM
{a.MODEL_SUMMARY_TABLE})::INTEGER
+ AS metrics_compute_frequency,
+ $MAD${self.name}$MAD$::TEXT AS name,
+ $MAD${self.description}$MAD$::TEXT AS description,
Review comment:
```suggestion
{name}::TEXT AS name,
{descr}::TEXT AS description,
```
As we have the code to check for NULL and add `$MAD$` in L180-181.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
