reductionista commented on a change in pull request #524:
URL: https://github.com/apache/madlib/pull/524#discussion_r574767403
##########
File path:
src/ports/postgres/modules/deep_learning/test/madlib_keras_automl.sql_in
##########
@@ -329,7 +330,8 @@ DROP TABLE IF EXISTS automl_output, automl_output_info,
automl_output_summary, a
SELECT madlib_keras_automl('iris_data_packed', 'automl_output',
'iris_model_arch', 'automl_mst_table',
ARRAY[1,2], $${'loss': ['categorical_crossentropy'],
'optimizer_params_list': [ {'optimizer': ['Adagrad', 'Adam'],
'lr': [0.9, 0.95, 'log'], 'epsilon': [0.3, 0.5, 'log_near_one']},
{'optimizer': ['Adam', 'SGD'],
- 'lr': [0.6, 0.65, 'log']} ], 'metrics':['accuracy'] }$$, $${'batch_size':
[2, 4], 'epochs': [3]}$$);
+ 'lr': [0.6, 0.65, 'log']} ], 'metrics':['accuracy'] }$$,
+ $${'batch_size': [2, 4], 'epochs': [3], 'callbacks':
['[TensorBoard(log_dir=\'/tmp/tensorflow/scalars/\')]']}$$);
Review comment:
Alternatively, we could decide to treat callbacks specially, knowing
that it's supposed to be a list. Currently, if they pass something like this:
```
'callbacks' : [ 'TensorBoard(log_dir="/tmp/tensorflow/scalars/")' ]
```
it will try to pass
param_value = 'TensorBoard(log_dir="/tmp/tensorflow/scalars/")'
We could do a `param_value = '[{}]'.format(param_value)` before it gets
evaluated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
