reductionista commented on a change in pull request #524:
URL: https://github.com/apache/madlib/pull/524#discussion_r583238518
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
##########
@@ -170,11 +173,19 @@ def convert_string_of_args_to_dict(str_of_args):
elif not stack and char == ",":
value_str = result_str
result_str = ""
- compile_dict[key_str.strip()]=value_str.strip().strip('\'')
+ key_str = key_str.strip()
+ value_str = value_str.strip()
+ if strip_quotes:
+ value_str = value_str.strip('"\'')
+ compile_dict[key_str.strip()]=value_str
Review comment:
Good catch, we can remove one of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
