kaknikhil opened a new pull request #557: URL: https://github.com/apache/madlib/pull/557
JIRA: MADLIB-1471 When passing in the weights param as a column in the table, it would fail with the error `column does not exist`. This column was missed when calling the step function. If it were passed in as a constant value, this would work fine. We fixed this by adding the weights column to the normalized/scaled table. Additionally, there was a bug in validating the weights column type, it validated only for integer and float types and would fail for other numeric types. The intented column type was all numeric types. This commit fixes both these bugs and adds tests for passing in weights as a table column. Co-authored-by: Ekta Khanna <ekha...@vmware.com> <!-- Thanks for sending a pull request! Here are some tips for you: 1. Refer to this link for contribution guidelines https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines 2. Please Provide the Module Name, a JIRA Number and a short description about your changes. --> - [ ] Add the module name, JIRA# to PR/commit and description. - [ ] Add tests for the change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
