reductionista commented on a change in pull request #524:
URL: https://github.com/apache/madlib/pull/524#discussion_r589816588
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
##########
@@ -287,27 +298,50 @@ def parse_optimizer(compile_dict):
# Parse the fit parameters into a dictionary.
-def parse_and_validate_fit_params(fit_param_str):
+def parse_and_validate_fit_params(fit_param_str, current_seg_id=0):
Review comment:
I like -1 better as well... if someone is trying to debug a problem and
they see segment_id=-1 printed out, that will be more helpful and less prone to
confusion than if it shows up as segment_id=0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
