reductionista commented on pull request #556: URL: https://github.com/apache/madlib/pull/556#issuecomment-796348743
Without the cmake flag set, it passes all install-check and dev-check tests on these platforms: CentOS 6.10 / gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) / cmake 3.5.2 CentOS 6.10 / (GCC) 6.2.0, 64-bit / cmake 3.5.2 Centos 7 / (GCC) 6.2.0, 64-bit / cmake 3.5.2 Ubuntu 16 / gcc 6.2.0 / cmake 3.5.2 Ubuntu 18 / gcc 6.2.0 / cmake 3.5.2 MacOS Catalina / gcc / cmake MacOS Big Sur / gcc (Homebrew GCC 8.2.0) 8.2.0 / cmake 3.18.4 With CXX11=1 set, it compiles and passes most of the install-check and dev-check tests on these platforms: CentOS 6.10 / gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) / cmake 3.5.2 CentOS 6.10 / (GCC) 6.2.0, 64-bit / cmake 3.5.2 Centos 7 / (GCC) 6.2.0, 64-bit / cmake 3.5.2 Ubuntu 16 / gcc 6.2.0 / cmake 3.5.2 Ubuntu 18 / gcc 6.2.0 / cmake 3.5.2 MacOS Big Sur / Apple clang version 12.0.0 (clang-1200.0.32.29) / cmake 3.18.4 C++11 support is still "experimental" so we're okay for now with some tests failing for C++11 in kmeans, linalg, and recursive_partition. Lowering the optimization helps get rid of some of them, but not all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org