kaknikhil commented on a change in pull request #572:
URL: https://github.com/apache/madlib/pull/572#discussion_r675923863
##########
File path: deploy/gppkg/madlib.spec.in
##########
@@ -54,6 +54,8 @@ ln -nsf $RPM_INSTALL_PREFIX/madlib/Versions/$MADLIB_VERSION
$RPM_INSTALL_PREFIX/
ln -nsf $RPM_INSTALL_PREFIX/madlib/Current/bin $RPM_INSTALL_PREFIX/madlib/bin
ln -nsf $RPM_INSTALL_PREFIX/madlib/Current/doc $RPM_INSTALL_PREFIX/madlib/doc
+ln -nsf
$RPM_INSTALL_PREFIX/madlib/Current/ports/greenplum/@GPDB_VERSION@/lib/libmadlib.so
$RPM_INSTALL_PREFIX/lib/postgresql/
Review comment:
Suggestion: What do you think about being explicit about the symlink
name i.e.
```
ln -snf
$RPM_INSTALL_PREFIX/madlib/Current/ports/greenplum/@GPDB_VERSION@/lib/libmadlib.so
$RPM_INSTALL_PREFIX/lib/postgresql/libmadlib.so
```
Both of them achieve the same result but this one is a bit more explicit and
maybe easier to read . What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
