khannaekta commented on code in PR #580:
URL: https://github.com/apache/madlib/pull/580#discussion_r868585628
##########
src/ports/postgres/modules/convex/mlp.sql_in:
##########
@@ -1346,99 +1349,6 @@ JOIN mlp_regress_prediction USING (id);
(1 row)
</pre>
-<h4>Regression with Grouping and Mini-Batching</h4>
Review Comment:
Why did we remove this?
##########
tool/docker_start.sh:
##########
@@ -83,9 +83,10 @@ docker exec "${CONTAINER_NAME}" bash -c "rm -rf
/madlib/build_docker; \
echo "---------- Installing and running install-check --------------------"
# Install MADlib and run install check
-docker exec "${CONTAINER_NAME}" bash -c "/madlib/build_docker/src/bin/madpack
-p postgres \
- -c
postgres/postgres@localhost:5432/postgres \
- install" \
+docker exec "${CONTAINER_NAME}" bash -c "PATH=$PATH:/usr/lib/postgresql/10/bin
\
+
/madlib/build_docker/src/bin/madpack -p postgres \
+ -c
postgres/postgres@localhost:5432/postgres \
+ install" \
| tee "${workdir}/build_docker_logs/madlib_install.log"
docker exec "${CONTAINER_NAME}" bash -c "/madlib/build_docker/src/bin/madpack
-p postgres \
Review Comment:
Do we also need to update the PATH here for install-check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@madlib.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
