khannaekta commented on code in PR #600:
URL: https://github.com/apache/madlib/pull/600#discussion_r1146776933
##########
src/ports/postgres/modules/deep_learning/madlib_keras.py_in:
##########
@@ -250,20 +250,20 @@ def fit(schema_madlib, source_table, model,
model_arch_table,
[serialized_weights,
custom_function_map]
)[0]['iteration_result']
except plpy.SPIError as e:
- msg = e.args[0]
- if 'TransAggDetail' in msg:
- e.args[0], detail = msg.split('TransAggDetail')
- elif 'MergeAggDetail' in msg:
- e.args[0], detail = msg.split('MergeAggDetail')
- elif 'FinalAggDetail' in msg:
- e.args[0], detail = msg.split('FinalAggDetail')
- else:
- raise e
- # Extract Traceback from segment, add to
- # DETAIL of error message on coordinator
- spidata = list(e.spidata)
- spidata[1] = detail
- e.spidata = tuple(spidata)
+ # msg = e.args[0]
+ # if 'TransAggDetail' in msg:
+ # e.args[0], detail = msg.split('TransAggDetail')
+ # elif 'MergeAggDetail' in msg:
+ # e.args[0], detail = msg.split('MergeAggDetail')
+ # elif 'FinalAggDetail' in msg:
+ # e.args[0], detail = msg.split('FinalAggDetail')
+ # else:
+ # raise e
+ # # Extract Traceback from segment, add to
+ # # DETAIL of error message on coordinator
+ # spidata = list(e.spidata)
+ # spidata[1] = detail
+ # e.spidata = tuple(spidata)
Review Comment:
Lets add a FIXME here to take care of this later.
##########
src/ports/postgres/modules/utilities/debug.py_in:
##########
@@ -183,17 +183,17 @@ def plpy_execute(*args, **kwargs):
try:
res = plpy.execute(*args, **kwargs)
except plpy.SPIError as e:
- msg = e.message
- if 'SegmentTraceback' in msg:
- e.message, detail = msg.split('SegmentTraceback')
- else:
- raise e
- # Extract Traceback from segment, add to
- # DETAIL of error message on coordinator
- e.args = (e.message,)
- spidata = list(e.spidata)
- spidata[1] = detail
- e.spidata = tuple(spidata)
+ # msg = e.args[0]
+ # if 'SegmentTraceback' in msg:
+ # e.args[0], detail = msg.split('SegmentTraceback')
+ # else:
+ # raise e
+ # # Extract Traceback from segment, add to
+ # # DETAIL of error message on coordinator
+ # e.args = (e.args[0],)
+ # spidata = list(e.spidata)
+ # spidata[1] = detail
+ # e.spidata = tuple(spidata)
Review Comment:
Add a FIXME to take care of it in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@madlib.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
