Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/10#discussion_r51925561
  
    --- Diff: methods/array_ops/src/pg_gp/array_ops.c ---
    @@ -1929,3 +1971,126 @@ General_Array_to_Array(
         return pgarray;
     }
     
    +/******* internal functions ********/
    --- End diff --
    
    This function would be much easier to code and maintain if we used the 
abstraction layer + eigen to compute the matrix dot product. See 
closestColumnsAndDistances in metric.cpp for an example of how a matrix and a 
vector are used in an operation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to