Github user decibel commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/29#discussion_r57410192
--- Diff: src/ports/postgres/modules/utilities/path.py_in ---
@@ -108,8 +107,11 @@ def path(schema_madlib, source_table, output_table,
partition_expr,
*,
nextval('{seq_gen}') AS {id_col_name},
--- End diff --
What are you basing that on? I don't believe there's any significant
performance benefit to sequences over row_number() (actually, a quick glance at
the code leads me to think sequences will be slower). On top of that, creating
a sequence adds to catalog bloat (not to mention the cost of creating and then
dropping the sequence).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
