Reminder to please vote today on RC-2 as vote closes at 6 pm Pacific today.
thanks, Frank On Fri, Mar 3, 2017 at 8:26 PM, Ed Espino <esp...@apache.org> wrote: > I had some time and had been wanting to perform a MADlib build. Here are > my notes from my quick review of MADlib v1.10-rc2. Sorry if the information > is a bit scattered. > > Regards, > -=ed espino > > ====================================================================== > Checksums are good > ====================================================================== > PGP signature is good > ====================================================================== > Extracted tarball base directory (apache-madlib-src-1.10-incubating) > good > ====================================================================== > LICENSE > > Shouldn't the components with files in licenses/third_party be > referenced in LICENSE file? > > Boost_Software_License_v1.txt > Eigen_v3.1.2.txt > PyXB_v1.2.3.txt > PyYAML_v3.10.txt > Python_License_v2.7.1.txt > UseLATEX_v1.9.4.txt > _M_widen_init.txt > argparse_v1.2.1.txt > > From README.md, I only saw an incomplete reference to the third party > components. > > Third Party Components > MADlib incorporates material from the following third-party components > > argparse 1.2.1 "provides an easy, declarative interface for creating > command line tools" > Boost 1.47.0 (or newer) "provides peer-reviewed portable C++ source > libraries" > Eigen 3.2.2 "is a C++ template library for linear algebra" > PyYAML 3.10 "is a YAML parser and emitter for Python" > PyXB 1.2.4 "is a Python library for XML Schema Bindings" > > ====================================================================== > DISCLAIMER good > ====================================================================== > NOTICE good > ====================================================================== > BUILD, INSTALL and INSTALL-CHECK > > I was able to build the package and successfully ran MADlib > install-check against PostgreSQL 9.6.2. > > Issue: There is no obvious reference to the PostgreSQL libxml > dependency in dev documentation. The madpack install-check > has failures (see below) if "--with-libxml" configure > option is not specified for PostgreSQL. > > install-check errors encountered due to PostgreSQL > configuration without "--with-libxml" option: > > psql:/tmp/madlib.0UIPlZ/pmml/test/table_to_pmml.sql_in.tmp:73: > ERROR: unsupported XML feature > DETAIL: This functionality requires the server to be built with > libxml support. > HINT: You need to rebuild PostgreSQL using --with-libxml. > CONTEXT: while creating return value > PL/Python function "pmml" > > Issue: AUTO DOWNLOADED PACKAGES > > I was performing the build from a simple perspective. Download > source, configure, make and glance at docs (in this order). > > As we have dealt with auto-downloaded files in the HAWQ project, I > was a surprised that the following packages were automatically > downloaded for me. On the HAWQ project we were instructed to require > these as pre-requisites and or make them optional included via > command line options (configure). I'm guessing other packages would > have been automatically downloaded if they were not found on system > (eg: boost). > > Automatically downloaded packages: > > https://github.com/madlib/eigen/archive/branches/3.2.tar.gz > http://sourceforge.net/projects/pyxb/files/PyXB-1.2.4.tar.gz > > Issue: As "make" was running, the following message was a bit alarming: > PyXB: Removing GPL component from code base > > This comes from the script src/patch/PyXB.sh run after PyXB source > is downloaded. > > ... > echo "PyXB: Removing GPL component from code base" > rm -f doc/extapi.py > rm -f doc/extapi.pyc > > ====================================================================== > JIRA: There is one open Jira for the fix-version v1.10: > https://issues.apache.org/jira/browse/MADLIB-1005 > ====================================================================== > PRODUCT VERSION > > After building from source, shouldn't the version contain the string > "incubating" somwehere? > > /usr/local/madlib/bin/madpack version > madpack.py : INFO : MADlib tools version = 1.10.0 > (/usr/local/madlib/Versions/1.10.0/bin/../madpack/madpack.py) > > ====================================================================== > > ---------------------------------------------------------------------- > Attached to this email: For reference: here is the entire build log > (including PostgreSQL 9.6.2) and test run attempts. Several of the > issues above can be seen in the log. > ---------------------------------------------------------------------- > > > On Fri, Mar 3, 2017 at 4:20 PM, Orhan Kislal <okis...@pivotal.io> wrote: > >> +1 >> >> On Fri, Mar 3, 2017 at 4:14 PM, Rahul Iyer <rahulri...@gmail.com> wrote: >> >> > +1 >> > >> > On Fri, Mar 3, 2017 at 11:17 AM, Frank McQuillan <fmcquil...@pivotal.io >> > >> > wrote: >> > >> > > Hello MADlib community, >> > > >> > > I am sending this email on behalf of the release manager Satoshi >> > Nagayasu < >> > > sn...@uptime.jp> . >> > > >> > > We have created a MADlib 1.10 RC-2, with the artifacts below up for a >> > vote. >> > > >> > > From project mentor Roman Shaposhnik we heard the ultimate resolution >> on >> > > the IP issue: >> > > * we don't do anything with existing (BSD) files even if we edit >> them >> > > * every new file we create gets an ASF license header >> > > * more details: >> > > >> > > https://issues.apache.org/jira/browse/LEGAL-293? >> > focusedCommentId=15881595& >> > > page=com.atlassian.jira.plugin.system.issuetabpanels: >> > > comment-tabpanel#comment-15881595 >> > > >> > > RC-2 replaces RC-1 with the following changes: >> > > >> > > * Multiple: Update license headers per Apache guidance >> > > https://github.com/apache/incubator-madlib/commit/ >> > > a3863b6c2407eb28ba007f6288d167bf88674e6d >> > > >> > > * Build: Fix module sort order for PGXN installation >> > > https://github.com/apache/incubator-madlib/commit/ >> > > fa80240f72a6551c2ee567d471afa499fd1d1efe >> > > >> > > * Update the copyright year. >> > > https://github.com/apache/incubator-madlib/commit/ >> > > 0b8415e7eec5c9ebb83fbf22923c69a99b0056ef >> > > >> > > * Build: Add error for missing server includedir >> > > https://github.com/apache/incubator-madlib/commit/ >> > > b3495c50bf491139ac245a21d97963e81892c610 >> > > >> > > * Encode categorical: Add distributed_by in Postgresql w/ no-op >> > > https://github.com/apache/incubator-madlib/commit/ >> > > 7055dceb3fbde35bae602ac80d4b70486f015748 >> > > >> > > * Renamed the top level source directory as suggested: >> > > apache-madlib-src-1.10-incubating >> > > >> > > This will be the 4th release for Apache MADlib (incubating). >> > > >> > > The main goals of this release are: >> > > * new modules (single source shortest path for graph analytics, encode >> > > categorical variables, K-nearest neighbors) >> > > * improvements to existing modules (add grouping support to elastic >> > > net and PCA, add cross validation to elastic net, array input for >> > > K-means, verbose output option for DT and RF, limit itemset size in >> > > association rules, various madpack installer improvements) >> > > * platform updates (PostgreSQL 9.6) >> > > * bug fixes >> > > * doc improvements >> > > >> > > For more information including release notes, please see: >> > > https://cwiki.apache.org/confluence/display/MADLIB/MADlib+1.10 >> > > >> > > *** Please download, review and vote by Mon Mar 6, 2017 @ 6pm Pacific >> > Time >> > > USA *** >> > > >> > > We're voting upon the source (tag): rc/1.10.0-rc2 >> > > https://github.com/apache/incubator-madlib/tree/rc/1.10.0-rc2 >> > > >> > > Source Files: >> > > https://dist.apache.org/repos/dist/dev/incubator/madlib/1. >> > > 10.0-incubating-rc2/ >> > > >> > > Commit to be voted upon: >> > > https://github.com/apache/incubator-madlib/commit/ >> > > a3863b6c2407eb28ba007f6288d167bf88674e6d >> > > >> > > KEYS file containing PGP Keys we use to sign the release: >> > > https://dist.apache.org/repos/dist/dev/incubator/madlib/KEYS >> > > >> > > To help in tallying the vote, can PMC members please be sure to >> > > indicate "(binding)" with their vote. >> > > >> > > [ ] +1 approve >> > > [ ] +0 no opinion >> > > [ ] -1 disapprove (and reason why) >> > > >> > > Regards, >> > > Frank McQuillan >> > > >> > >> > >
