Github user orhankislal commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/108#discussion_r107778273
  
    --- Diff: src/ports/postgres/modules/utilities/pivot.py_in ---
    @@ -222,59 +261,78 @@ def pivot(schema_madlib, source_table, out_table, 
index, pivot_cols,
     
                             # Collect pcol values for the dict
                             if output_col_dictionary:
    -                            insert_str.append("{0}".format(
    +                            dict_insert_str.append("'{0}'".format(
    --- End diff --
    
    Is there a particular reason this is needed? The install-check fails on 
NULL values and removing them seems to solve the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to