Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/129#discussion_r114846053
--- Diff:
src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in ---
@@ -157,25 +150,24 @@ def _classify_features(feature_to_type, features):
cat_types = int_types + text_types + boolean_types
ordered_cat_types = int_types
- cat_features = [c for c in features
- if _dict_get_quoted(feature_to_type, c) in cat_types]
- ordered_cat_features = [c for c in features if _dict_get_quoted(
- feature_to_type, c) in ordered_cat_types]
+ cat_features = [c for c in features if feature_to_type[c] in cat_types]
+ ordered_cat_features = [c for c in features
+ if feature_to_type[c] in ordered_cat_types]
cat_features_set = set(cat_features)
# continuous types - 'real' is cast to 'double precision' for
uniformity
- con_types = ['real', 'float8', 'double precision']
+ con_types = ['real', 'float8', 'double precision', 'numeric']
con_features = [c for c in features
if (c not in cat_features_set and
--- End diff --
do we need to check if `c not in cat_features_set`? At the moment, it seems
like `cat_types` and `con_types` are mutually exclusive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
