Github user haying commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/149#discussion_r126795536
  
    --- Diff: src/ports/postgres/dbconnector/TypeTraits_impl.hpp ---
    @@ -750,6 +784,30 @@ struct 
TypeTraits<dbal::eigen_integration::SparseColumnVector> {
         );
     };
     
    +template <>
    +struct TypeTraits<std::vector<uint16_t> > {
    +    typedef std::vector<uint16_t> value_type;
    +
    +    WITH_OID( INT4ARRAYOID );
    +    WITH_MUTABILITY( dbal::Mutable );
    +    WITH_DEFAULT_EXTENDED_TRAITS;
    +    // FIXME a quick hack
    --- End diff --
    
    Could we add a bit more details in the comment saying the cons of this hack 
and a potential direction for a future fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to