Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/149#discussion_r128588139
--- Diff: src/ports/postgres/modules/utilities/validate_args.py_in ---
@@ -458,6 +458,22 @@ def scalar_col_has_no_null(tbl, col):
# -------------------------------------------------------------------------
+def array_col_dimension(tbl, col):
+ """
+ What is the dimension of this array column
+ """
+ if tbl is None or tbl.lower() == 'null':
+ plpy.error('Input error: Table name (NULL) is invalid')
+ if col is None or col.lower() == 'null':
--- End diff --
IMO if we shouldn't be checking for the string 'NULL'. There are multiple
strings that are invalid table/column names - why make 'null' an exception?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
