Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/155#discussion_r129801476
  
    --- Diff: src/ports/postgres/modules/utilities/validate_args.py_in ---
    @@ -344,6 +344,50 @@ def get_cols_and_types(tbl):
         return list(zip(col_names, col_types))
     # -------------------------------------------------------------------------
     
    +def get_col_type(tbl, col):
    --- End diff --
    
    There's lots of code overlap with `get_cols_and_types`. We should avoid 
that redundancy. 
    Also, does `get_expr_type` not work for this need? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to