GitHub user iyerr3 opened a pull request:

    https://github.com/apache/incubator-madlib/pull/157

    Multiple: Check optimizer_control before updating optimizer

    JIRA: MADLIB-1109
    
    This is applicable only for the Greenplum and HAWQ platforms:
    
    We disable/enable ORCA using the 'optimizer' GUC in some functions for
    performance reasons. GPDB/HAWQ has another GUC 'optimizer_control' which
    allows the user to disable updates to the 'optimizer' GUC. Updating
    'optimizer' when 'optimizer_control = off' leads to an ugly error.
    
    This commit adds a check for the value of 'optimizer_control' and
    updates 'optimizer' only if 'optimizer_control = on'.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iyerr3/incubator-madlib 
bugfix/optimizer_control

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #157
    
----
commit b86eab834e0f56f5fcb501bf1ef50556000afe8b
Author: Rahul Iyer <ri...@apache.org>
Date:   2017-08-01T18:01:05Z

    Multiple: Check optimizer_control before updating optimizer
    
    JIRA: MADLIB-1109
    
    This is applicable only for the Greenplum and HAWQ platforms:
    
    We disable/enable ORCA using the 'optimizer' GUC in some functions for
    performance reasons. GPDB/HAWQ has another GUC 'optimizer_control' which
    allows the user to disable updates to the 'optimizer' GUC. Updating
    'optimizer' when 'optimizer_control = off' leads to an ugly error.
    
    This commit adds a check for the value of 'optimizer_control' and
    updates 'optimizer' only if 'optimizer_control = on'.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to