GitHub user iyerr3 opened a pull request:
https://github.com/apache/incubator-madlib/pull/171
DT: Correctly encode unseen categorical features
Changes applied in commit a2f4740 added an option to treat NULL values
as a new category. This was applied by changing the encoding process of
categorical features to add a new value at the end of the list of
values. The intention with the commit was to treat new unseen, non-null
values equivalent to NULL. The encoding process, however, still encoded
the unseen categorical value as -1, which is interpreted as NULL in
underlying functions. This commit updates this process to correctly use
the last index as the encoding for the unseen/NULL value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyerr3/incubator-madlib
bugfix/dt_unseen_encoding
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit 9f8722f410974ef27564623f44891ac2f95fd487
Author: Rahul Iyer <[email protected]>
Date: 2017-08-18T16:06:20Z
DT: Correctly encode unseen categorical features
Changes applied in commit a2f4740 added an option to treat NULL values
as a new category. This was applied by changing the encoding process of
categorical features to add a new value at the end of the list of
values. The intention with the commit was to treat new unseen, non-null
values equivalent to NULL. The encoding process, however, still encoded
the unseen categorical value as -1, which is interpreted as NULL in
underlying functions. This commit updates this process to correctly use
the last index as the encoding for the unseen/NULL value.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
