[ 
https://issues.apache.org/jira/browse/MAHOUT-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870260#action_12870260
 ] 

Jeff Eastman commented on MAHOUT-398:
-------------------------------------

Here's a very minimal fix that, imho, reduces the ambiguity and makes the 
contents of the vector directories much more obvious:

DictionaryVectorizer {
  
  public static final String DOCUMENT_VECTOR_OUTPUT_FOLDER = "tf-vectors";

TFIDFConverter {
  
   private static final String DOCUMENT_VECTOR_OUTPUT_FOLDER = "tfidf-vectors";



> Seq2sparse outputs final vectors to different directories depending upon the 
> TF/TFIDF weight switch. This is confusing to users.
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-398
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-398
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Utils
>    Affects Versions: 0.3
>            Reporter: Jeff Eastman
>             Fix For: 0.4
>
>
> In TF mode, seq2sparse puts the output vectors into <output>/vectors. In 
> TFIDF mode; however, it puts the output vectors into <output>/tfidf/vectors. 
> This happens because the IDF calculation - if it is selected - happens after 
> TF and uses the TF vectors for its input.
> Seems like both modes ought to output to a consistent directory structure so 
> changing the switch does not change the final output location: perhaps as 
> simple as changing TF to output to <output>/tf/vectors so that the contents 
> of both directories when present are more obvious from their nomenclature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to