[
https://issues.apache.org/jira/browse/MAHOUT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898751#action_12898751
]
Sean Owen commented on MAHOUT-460:
----------------------------------
I have some general comments and then believe you are welcome to commit.
- Your IDE seems to be reordering imports. I'd leave them as they are as
they're reasonably standard in ordering across the code.
- Some of the changes also seem to be changes in whitespace indentation --
should be 2 spaces per unit of indentation everywhere. For instance see
MaybePruneRowsMapper.countSeen()
- MathHelper: I wouldn't concatenate a string together with '+' and then append
to StringBuffer. Append each piece to take advantage of it.
- Also we should all use StringBuilder, not StringBuffer
- ToItemVectorsReducer: attach the Apache copyright header?
> Add "maxPreferencesPerItemConsidered" option to
> o.a.m.cf.taste.hadoop.similarity.item.ItemSimilarityJob
> -------------------------------------------------------------------------------------------------------
>
> Key: MAHOUT-460
> URL: https://issues.apache.org/jira/browse/MAHOUT-460
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Sebastian Schelter
> Attachments: MAHOUT-460.patch
>
>
> Because "coocurrence algorithms ... scale in the square of the number of
> occurrences most popular item" (Ted wrote that in a recent mail) we should
> offer a parameter to the ItemSimilarity job that makes it limit the number of
> considered preferences per item. RecommenderJob already has such an option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
