+1 That change would touch everything and for what? To avoid a couple extra vector wrappers, maybe an explicit cast and a bit more headache in VectorWritable? I'm happy to change WeightedVectorWritable back to not subclass VW or into a WeightedVector wrapper liked NamedVector. It's only used by the clustering steps and the cluster dumper anyway.

On 9/13/10 2:17 PM, Ted Dunning wrote:
No need to fix a problem until it exists.

On Mon, Sep 13, 2010 at 2:10 PM, Sean Owen<[email protected]>  wrote:

Adding a generic type means all "VectorWritable" become
"VectorWritable<Vector>" by default and that could be more mess than
it's worth. I'm leaning towards not adding that generic type.


Reply via email to