[
https://issues.apache.org/jira/browse/MAHOUT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917316#action_12917316
]
Sean Owen commented on MAHOUT-480:
----------------------------------
I think this is a fairly heroic effort to use Preconditions across the board.
My concern had been about getting into a half-way state where Preconditions was
used for some but not all such checking. It's the same sort of issue we'd
discussed any number of times about, say, half-using 3 logging systems is worse
than none at all, or same for 3 math libraries.
I find this less of an issue here -- not all arg checking can or must be done
with Preconditions. We have no existing consistent system to compete with.
And, it looks largely like mahout-core is updated. mahout-examples and
mahout-utils are not it seems. I could take that on as well as try to find more
instances where it can be used in mahout-core.
mahout-math, perhaps we should not introduce the dependency into.
> Replace manual precondition checking with Precondition utility class from
> Guava
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-480
> URL: https://issues.apache.org/jira/browse/MAHOUT-480
> Project: Mahout
> Issue Type: Improvement
> Components: Clustering
> Affects Versions: 0.3
> Reporter: Eugen Paraschiv
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.4
>
> Attachments: MAHOUT-480.patch, MAHOUT-480_v3.patch
>
>
> Replace manual precondition checking with the Precondition class. This will
> affect the following classes:
> FileDataModel
> MemoryDiffStorage
> SlopeOneRecommender
> FileDiffStorage
> AbstractJDBCDiffStorage
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
